Skip to content

CGPoint, CGSize, CGRect Conforms Hashable #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

KYHyeon
Copy link
Contributor

@KYHyeon KYHyeon commented Nov 13, 2024

fix #3443

@jmschonfeld
Copy link
Contributor

@KYHyeon thanks for providing this change! Since this is a change to public API, it should go through the Foundation evolution process described at https://github.com/swiftlang/swift-foundation/blob/main/Evolution.md before we land it. A pitch for this change would be great to update the non-Darwin APIs to be the same as the new Darwin APIs!

@jmschonfeld
Copy link
Contributor

@swift-ci please test

@KYHyeon
Copy link
Contributor Author

KYHyeon commented Nov 14, 2024

@jmschonfeld
It might be something I didn't understand
Core Graphics already supports Hashable on iOS 18+.
Do I still have to go through the foundation evolution?

https://developer.apple.com/documentation/corefoundation/cgrect

@jmschonfeld
Copy link
Contributor

Ah apologies for the confusion here - yeah this is an edge case since normally a change like this would go through evolution, however it's already shipped on Darwin (since on Darwin it ships as part of the CoreGraphics framework and not Foundation) so I spoke with @itingliu and I think in this situation it's probably fine to land this as-is to get feature parity between the platforms. Looks like Linux failed with a runtime crash but I'm not certain if it's related - let's see if a re-run sorts that out

@jmschonfeld
Copy link
Contributor

@swift-ci please test Linux platform

@jmschonfeld jmschonfeld merged commit c28bf23 into swiftlang:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SR-10476] CGPoint, CGSize, CGRect are Hashable in corelibs-Foundation, but not in Cocoa Foundation
2 participants