[CoreFoundation] Replace use of strlcpy/strlcat with our own functions. #5113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Windows platform |
parkera
approved these changes
Oct 17, 2024
|
We need the Windows build to pass, though... |
|
|
Oops, yes, that's wrong. Will fix and re-spin the tests. |
These can _use_ `strlcpy` and `strlcat` if we have them, but we mustn't go defining `strlcpy` or `strlcat` because (a) those names are reserved, and (b) doing so without explicitly testing for their presence runs the risk of build failures from trying to define them when they already exist. rdar://137567627
al45tair
force-pushed
the
eng/PR-137567627
branch
from
32616b6 to
5b60ddf
Compare
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Windows platform |
|
Hopefully fixed that one. That'll teach me to try to be clever and use the nice macro (the problem being that, of course, you can't use function macros in an expression if they're undefined, even after testing whether they're defined and doing an |
|
@swift-ci Please test Windows platform |
parkera
approved these changes
Oct 18, 2024
This was referenced Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can use
strlcpyandstrlcatif we have them, but we mustn't go definingstrlcpyorstrlcatbecause (a) those names are reserved, and (b) doing so without explicitly testing for their presence runs the risk of build failures from trying to define them when they already exist.rdar://137567627