[6.0] Implement Data reading hook for remote content #5058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
swiftlang/swift-foundation#826 @swift-ci please test |
|
swiftlang/swift-foundation#826 @swift-ci please test windows platform |
|
swiftlang/swift-foundation#826 @swift-ci please test windows platform |
itingliu
approved these changes
Aug 8, 2024
| .package( | ||
| url: "https://github.com/apple/swift-foundation", | ||
| revision: "d59046871c6b69a13595f18d334afa1553e0ba50") | ||
| branch: "release/6.0") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Implements the hook defined in swiftlang/swift-foundation#826 to allow for
Data(contentsOf:)to fetch from a remote URL when FoundationNetworking is loadedScope: Should only impact calling Data(contentsOf:) with a non-file URL, turning an error into non-regressed behavior
Original PR: #5049
Risk: Minimal - fixes a regression where the current behavior is just to throw, and fairly limited scope
Testing: Testing done via swift-ci testing and local testing
Reviewer: @iCharlesHu @parkera