Skip to content

[6.0] Update to use dynamic replacement for _NSNumberInitializer #5047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmschonfeld
Copy link
Contributor

Explanation: Removes a _typeByName lookup in a FoundationEssentials up-call that can result in confusion between the toolchain and local builds
Scope: Should only impact up-calls from FileManager in FoundationEssentials to initialize NSNumbers
Original PR: #5045
Risk: Low - small in scope and covered by unit tests
Testing: Testing done via swift-ci testing
Reviewer: @parkera

@jmschonfeld jmschonfeld requested a review from parkera August 2, 2024 17:43
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld requested a review from itingliu August 3, 2024 16:49
@itingliu
Copy link
Contributor

itingliu commented Aug 5, 2024

macOS CI failure looks unrelated to this PR but related to SwiftFoundation. Is that a known issue?

/Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-release/6.0/swift-corelibs-xctest/Sources/XCTest/Public/XCTestMain.swift:21:23: error: no such module 'SwiftFoundation'
    @_exported import SwiftFoundation
                      ^

@jmschonfeld
Copy link
Contributor Author

macOS CI failure looks unrelated to this PR but related to SwiftFoundation. Is that a known issue?

/Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-release/6.0/swift-corelibs-xctest/Sources/XCTest/Public/XCTestMain.swift:21:23: error: no such module 'SwiftFoundation'
    @_exported import SwiftFoundation
                      ^

Yep, this project no longer builds for macOS so the macOS CI is no longer relevant and is expected to fail. It isn't disabled, but it's no longer marked as a required check so that we can merge even when it fails (SwiftFoundation used to be the old name of the SCL-F module on Darwin, but now that SCL-F doesn't build for Darwin even for testing purposes, the SwiftFoundation module doesn't exist so XCTest tests on Darwin can't find it - which is fine).

@jmschonfeld jmschonfeld merged commit b43f178 into swiftlang:release/6.0 Aug 5, 2024
2 of 3 checks passed
@jmschonfeld jmschonfeld deleted the 6.0/dynamic-nsnumber-initializer branch August 5, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants