Fix CoreFoundation module install path for static build #5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jmschonfeld
force-pushed
the
restore-corefoundation-static-module
branch
from
600470a to
aa25f08
Compare
|
@swift-ci please test |
jmschonfeld
force-pushed
the
restore-corefoundation-static-module
branch
from
aa25f08 to
00f80b1
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
iCharlesHu
approved these changes
Aug 1, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-corelibs-foundation
that referenced
this pull request
Aug 1, 2024
jmschonfeld
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoreFoundation target had a hard-coded module install path of
lib/swift/CoreFoundation, instead of conditionalizing it for the static build (which goes tolib/swift_static). While we don't expect clients to useCoreFoundationdirectly (and they shouldn't), this restores the module to unbreak existing clients that are doing this.This resolves apple/swift-http-types#61