Re-core some String APIs on swift-foundation #5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmschonfeld
commented
Jul 17, 2024
| @@ -76,9 +76,9 @@ class TestDataURLProtocol: XCTestCase { | |||
| ("data:;charset=utf-16;base64,2D3caCAN2D3caCAN2D3cZyAN2D3cZw==", "👨👨👧👧", (expectedContentLength: 22, mimeType: "text/plain", textEncodingName: "utf-16")), | |||
| ("data:;charset=utf-16le;base64,Pdho3A0gPdho3A0gPdhn3A0gPdhn3A==", "👨👨👧👧", (expectedContentLength: 22, mimeType: "text/plain", textEncodingName: "utf-16le")), | |||
| ("data:;charset=utf-16be;base64,2D3caCAN2D3caCAN2D3cZyAN2D3cZw==", "👨👨👧👧", (expectedContentLength: 22, mimeType: "text/plain", textEncodingName: "utf-16be")), | |||
| ("data:application/json;charset=iso-8859-1;key=value,,123", ",123", (expectedContentLength: 4, mimeType: "application/json", textEncodingName: "iso-8859-1")), | |||
| // ("data:application/json;charset=iso-8859-1;key=value,,123", ",123", (expectedContentLength: 4, mimeType: "application/json", textEncodingName: "iso-8859-1")), | |||
There was a problem hiding this comment.
These are temporarily disabled until we can enable the isoLatin1 encoding in swift-foundation or add an up-call to SCL-F to handle the extra encodings beyond the standard UTF encodings
jmschonfeld
force-pushed
the
recore-string-data-encoding
branch
from
e1234ba to
c098501
Compare
jmschonfeld
commented
Jul 17, 2024
| @@ -297,6 +212,7 @@ extension String { | |||
| /// frees the buffer. | |||
| /// | |||
| /// - Warning: This initializer is not memory-safe! | |||
| @available(swift, deprecated: 6.0, message: "String does not support no-copy initialization") | |||
There was a problem hiding this comment.
These (and the other deprecated functions) are now deprecated on Darwin, so this updates these to match Darwin
| // | ||
| // This file is shared between two projects: | ||
| // | ||
| // 1. https://github.com/apple/swift/tree/master/stdlib/public/Darwin/Foundation |
There was a problem hiding this comment.
This file no longer exists / this is no longer the case, so we can remove this comment altogether
jmschonfeld
force-pushed
the
recore-string-data-encoding
branch
from
c098501 to
08744fc
Compare
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
parkera
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some String APIs in SCL-F in favor of those in swift-foundation and removes some
!DEPLOYMENT_RUNTIME_SWIFTpaths that are no longer relevant in this project. This depends on swiftlang/swift-foundation#739, so I'll update the commit hash in the package manifest and cmake files once that is merged before merging this