Skip to content

add support for riscv64 #4983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

futurejones
Copy link

Add support for riscv64 as host architecture.

@parkera
Copy link
Contributor

parkera commented Jun 18, 2024

Thanks @futurejones -- we are working on a brand new set of CMake configs in the package branch over here -- we should rebase this on top of that once it lands.

@jmschonfeld
Copy link
Contributor

I believe @iCharlesHu's changes to the cmake for the package branch will actually remove this manual list of architectures and instead ask the compiler for the architecture (which should eliminate the need for this change and others like it in the future). We should double check to confirm, but hopefully this should "Just Work" with the new cmake setup

@iCharlesHu
Copy link
Contributor

Ditto to what @jmschonfeld said. We are removing this list with #4959 and just ask the compiler at runtime.

@futurejones
Copy link
Author

futurejones commented Jul 6, 2024

@parkera @jmschonfeld @iCharlesHu
#4959 has now been merged but it appears no changes were made with the use of the SwiftSupport.cmake file.
The file still exists and is is still referenced in the CMakeLists.txt file.
https://github.com/apple/swift-corelibs-foundation/blob/ca3669eb9ac282c649e71824d9357dbe140c8251/CMakeLists.txt#L67
https://github.com/apple/swift-corelibs-foundation/blob/main/cmake/modules/SwiftSupport.cmake

Am I missing something?
Thanks.

@jmschonfeld
Copy link
Contributor

@futurejones that PR was merged into the package branch, which is where ongoing work is taking place to re-core this repo on the new swift-foundation repo. That branch is expected to be merged into main imminently as soon as we resolve the final blockers. You can view the new contents of that file on the package branch at https://github.com/apple/swift-corelibs-foundation/blob/package/cmake/modules/FoundationSwiftSupport.cmake and this is the file that will be merged to main shortly (and you can see in that file that the list of architectures is removed)

@jmschonfeld
Copy link
Contributor

The package branch has now been merged to main so I believe this support should now be available for you on main

@futurejones
Copy link
Author

@jmschonfeld Thank you,
Closing this PR as issue has been solved with PR #4959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants