Mark Bundle as Sendable #4963
Merged
Mark Bundle as Sendable #4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jmschonfeld
approved these changes
May 23, 2024
kkebo
added a commit
to kkebo/zyphy
that referenced
this pull request
May 25, 2024
`Bundle` has been `Sendable` since swiftlang/swift-corelibs-foundation#4963, so we no longer need workarounds.
kkebo
added a commit
to kkebo/zyphy
that referenced
this pull request
May 30, 2024
`Bundle` has been `Sendable` since swiftlang/swift-corelibs-foundation#4963, so we no longer need workarounds.
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 11, 2024
Foundation added this conformance on their side in `main` (swiftlang/swift-corelibs-foundation#4963) and `release/6.0` (swiftlang/swift-corelibs-foundation#4978). rdar://129599679
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 11, 2024
Foundation added this conformance on their side in `main` (swiftlang/swift-corelibs-foundation#4963) and `release/6.0` (swiftlang/swift-corelibs-foundation#4978). rdar://129599679
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 12, 2024
Foundation added this conformance on their side in `main` (swiftlang/swift-corelibs-foundation#4963) and `release/6.0` (swiftlang/swift-corelibs-foundation#4978). rdar://129599679
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 13, 2024
Cherry-pick of #7652. **Explanation**: We shouldn't have two `Sendable` conformances on `Bundle` at the same time, and Foundation added this on their side in `main` (swiftlang/swift-corelibs-foundation#4963) and `release/6.0` (swiftlang/swift-corelibs-foundation#4978). **Scope**: isolated to bundle resources. **Risk**: low, the corresponding change on `main` branch of `swift-corelibs-foundation` was there for 3 weeks. **Testing**: covered by existing tests and the compat suite. **Issue**: rdar://129599679 **Reviewer**: @parkera, @bnbarham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFBundle, which this is a wrapper for, is thread safe, and NSBundle is marked as Sendable on Darwin. Since swift package manager inserts references to Bundle when using resources, it is important to make sure this type doesn't produce any warnings in Swift 6 mode.