[5.10] Removing checks for deleted timezones #4960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
shahmishal
approved these changes
May 19, 2024
parkera
approved these changes
May 20, 2024
compnerd
approved these changes
May 22, 2024
Recent Linux distributions no longer carry some deprecated timezones. Removing them, or replacing with the equivalent timezone, according to the contents of `/usr/share/zoneinfo` across the years of Linux that we are currently supporting. Removed timezones include: - Israel -> Asia/Jerusalem - US/Pacific -> America/Los_Angeles - Brazil/East -> America/Sao_Paulo Unfortunately, the 'Europe/Kyiv'/'Europe/Kiev' timezone has changed around a bit in the past few years, likely as a result of political events. As a result, I don't think I have a single spelling that will work across all of the versions of OS's that we are trying to support. If we really want to ensure that the tests are testing that Foundation can load timezone information and not test the current political events, it would likely be a good idea to save a couple of timezone files off for testing purposes and use those across OS versions instead of hoping that the list of timezones doesn't change from year-to-year. For now, I'm going to point the test at London instead. The daylight savings time shifted on the same date in 2020, so there is no other change to the test needed.
etcwilde
force-pushed
the
ewilde/remove-removed-timezones
branch
from
c1930b7 to
fd74a7a
Compare
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux distros that have picked up newer copies of the
tzdatadatabase have dropped some of the timezones tested in corelibs-foundation. Removing them, or replacing with the equivalent timezone replacement, according to the contents of/usr/share/zoneinfoon Ubuntu 23.10.Removed timezones include: