Skip to content

Stream: add missing include for macOS builds #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

From the swift-corelibs-xctest CI:

swift-corelibs-foundation/CoreFoundation/Stream.subproj/CFStream.c:1686:5: error: call to undeclared function '_CFThreadSetName'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    _CFThreadSetName(pthread_self(), "com.apple.CFStream.LegacyThread");
    ^

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

PR#4870 introduced a new CPP macro to allow building on non-threaded
systems, but in the process regressed the macOS build. Add the requisite
macro to enable the builds to function properly.
@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd compnerd closed this Feb 29, 2024
@compnerd compnerd deleted the include branch February 29, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant