[wasm][build] Handle FOUNDATION_BUILD_TOOLS value set to OFF
#4868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
approved these changes
Feb 7, 2024
|
@swift-ci test |
compnerd
requested changes
Feb 19, 2024
Sources/CMakeLists.txt
Outdated
| @@ -2,4 +2,6 @@ add_subdirectory(UUID) | |||
| add_subdirectory(Foundation) | |||
| add_subdirectory(FoundationNetworking) | |||
| add_subdirectory(FoundationXML) | |||
| add_subdirectory(Tools) | |||
| if(BUILD_TOOLS) | |||
There was a problem hiding this comment.
This is not a standard CMake flag. Can you create a proper option for this for something like FOUNDATION_BUILD_TOOLS? We can control the default for it to disable it by default on WASM targets if desired.
There was a problem hiding this comment.
The option is already declared here as option https://github.com/apple/swift-corelibs-foundation/blob/7f62c8c52aeed9a86b503fe7b662c48eda5d0f8a/CMakeLists.txt#L43 but I agree the option name should be prefixed by FOUNDATION
This is a follow up to 5e7281b, which just adds the `BUILD_TOOLS` option but doesn't actually use it. This patch renames the option to follow the CMake conventions and uses it to actually exclude the tools from the build.
kateinoigakukun
force-pushed
the
pr-972effe45a04043fc1aba1eaa9209ac85b3f9c85
branch
from
56330a7 to
004a9dd
Compare
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
FOUNDATION_BUILD_TOOLS value set to OFF
|
@swift-ci test windows |
compnerd
approved these changes
Feb 22, 2024
kateinoigakukun
deleted the
pr-972effe45a04043fc1aba1eaa9209ac85b3f9c85
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to 5e7281b, which just adds the
BUILD_TOOLSoption but doesn't actually use it.