Skip to content

[wasm][build] Guard libdispatch and Threads usage with HAS_LIBDISPATCH_API #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kateinoigakukun
Copy link
Member

This is a follow-up to 5e7281b to make it possible to turn them off when building for that platform.

@kateinoigakukun
Copy link
Member Author

@swift-ci test

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@MaxDesiatov MaxDesiatov added bug WASI WebAssembly System Interface-related changes labels Feb 7, 2024
@kateinoigakukun
Copy link
Member Author

Hmm, is this build failure tracked by somewhere?

https://ci.swift.org/job/swift-corelibs-foundation-PR-macOS/356/

/Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/swift-corelibs-foundation/CoreFoundation/Locale.subproj/CFLocale.c:1277:50: error: initializer element is not a compile-time constant
    static CFStringRef const kCFLocaleCodesKey = CFSTR("__kCFLocaleCodes");
                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~

@MaxDesiatov
Copy link
Contributor

cc @parkera for the macOS CI failure

@kateinoigakukun
Copy link
Member Author

Looks like it's broken after upgrading clang in CI. I guess the upstream CoreFoundation for Apple platforms already fixed it, so I'd like to wait to sync with the upstream instead of introducing a different fix than the upstream.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is ideal to support, but, we can leave this be for now.

@kateinoigakukun kateinoigakukun merged commit 2b752a5 into swiftlang:main Feb 22, 2024
@kateinoigakukun kateinoigakukun deleted the pr-7f195656e3309a1be99a234eb27e067d15e44dbf branch February 22, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug WASI WebAssembly System Interface-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants