[runloop] Fix the failure memory order argument to atomic_compare_exchange_strong_explicit #4855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange_strong_explicit The failure memory order cannot be release or acq_rel. Clang since llvm/llvm-project@fed5644 diagnoses an invalid argument.
|
@compnerd please take a look at this |
AZero13
reviewed
Dec 24, 2023
| @@ -1306,7 +1306,7 @@ static Boolean __CFRunLoopSourceIsSignaled(CFRunLoopSourceRef rls) { | |||
| } | |||
|
|
|||
| CF_INLINE void __CFRunLoopSourceSetSignaled(CFRunLoopSourceRef rls) { | |||
| atomic_compare_exchange_strong_explicit(&rls->_signaledTime, &(uint64_t){0}, mach_absolute_time(), memory_order_acq_rel, memory_order_acq_rel); | |||
| atomic_compare_exchange_strong_explicit(&rls->_signaledTime, &(uint64_t){0}, mach_absolute_time(), memory_order_acq_rel, memory_order_acquire); | |||
There was a problem hiding this comment.
After more testing, just go with
CF_INLINE void __CFRunLoopSourceSetSignaled(CFRunLoopSourceRef rls) {
uint64_t zero = 0;
atomic_compare_exchange_strong_explicit(&rls->_signaledTime, &zero, mach_absolute_time(), memory_order_release, memory_order_relaxed);
}
Azoy
approved these changes
Jan 5, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure memory order cannot be release or acq_rel. Clang since llvm/llvm-project@fed5644 diagnoses an invalid argument.