JSONDecoder.readString(): throw on invalid UTF-8 #4675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String(decoding:as:), which previously used by JSONDecoder.readString() to make string from JSON bytes, would silently repair invalid UTF-8 sequence and not throw a error. This commit uses String(bytes:encoding:) instead, which will fail on invalid UTF-8 seqence. This matches the behavior of Darwin Foundation. (Some examples of invalid UTF-8: http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt)
|
@swift-ci test |
|
@swift-ci test Windows |
kperryua
reviewed
Dec 13, 2022
|
@swift-ci test |
|
@MaxDesiatov Why is macOS test failing? Shall I care about that?
|
kperryua
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Changes look fine.
Something seems wrong infrastructurally in the CI:
dyld: Library not loaded: @rpath/lib_SwiftSyntaxMacros.dylib
Referenced from: /Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc
Reason: image not found
|
@shahmishal Can you help out with the build failiure? |
This comment was marked as duplicate.
This comment was marked as duplicate.
4 similar comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
Thank you! Sorry for the long delay while we figured out the CI issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String(decoding:as:), which previously used by
JSONDecoder.readString() to make string from JSON bytes, would silently repair invalid UTF-8 sequence and not throw a error.
This commit uses String(bytes:encoding:) instead,
which will fail on invalid UTF-8 seqence.
This matches the behavior of Darwin Foundation.
(Some examples of invalid UTF-8: http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt)