Skip to content

[5.5] Url components.percent encoded query items #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lha
Copy link

@lha lha commented Oct 29, 2021

Fixes SR-12340

fixed on main with #3096

Please consider for including in an upcoming 5.5 bug fix release for platform using swift-corelibs-foundation.

cc @millenomi @tomerd

Love Hörnquist Åstrand added 2 commits October 28, 2021 21:35
Some code with queryItems, use existing code in CFNetwork

Fixes SR-12340
@millenomi
Copy link
Contributor

@tomerd This improves compatibility with Darwin source. We would like it to be included in the next monthly release.

@millenomi
Copy link
Contributor

@swift-ci please test

@millenomi
Copy link
Contributor

@parkera per @shahmishal, the person designated release manager for swift-corelibs-foundation (you) has to approve patches targeted to release/5.5 for monthly Linux releases.

@shahmishal
Copy link
Member

@swift-ci test

@lha
Copy link
Author

lha commented Nov 16, 2021

any update ? @shahmishal

@parkera
Copy link
Contributor

parkera commented Dec 3, 2021

Looks good to me.

@parkera parkera self-requested a review December 3, 2021 19:38
@millenomi millenomi merged commit c8c2525 into swiftlang:release/5.5 Dec 3, 2021
@lha lha deleted the URLComponents.percentEncodedQueryItems-5.5 branch December 3, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants