Modernize code to not rely on deprecations and old behavior #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @etcwilde |
|
@swift-ci please test and merge |
AZero13
force-pushed
the
deprecated
branch
4 times, most recently
from
99647c0 to
31edb2d
Compare
|
@millenomi Could you please try the command again |
AZero13
force-pushed
the
deprecated
branch
6 times, most recently
from
ab6732a to
bfbc332
Compare
|
@swift-ci please test |
|
Thank you |
AZero13
changed the title
AZero13
force-pushed
the
deprecated
branch
2 times, most recently
from
4f3197b to
d49c2ba
Compare
|
@swift-ci please test |
AZero13
force-pushed
the
deprecated
branch
2 times, most recently
from
e8ac454 to
df8671a
Compare
AZero13
force-pushed
the
deprecated
branch
2 times, most recently
from
f9b0e8c to
7b5a16e
Compare
|
@millenomi Can we try again? |
AZero13
force-pushed
the
deprecated
branch
2 times, most recently
from
02c23cf to
022c199
Compare
AZero13
force-pushed
the
deprecated
branch
3 times, most recently
from
cf0138f to
3f0e844
Compare
|
@parkera @millenomi @etcwilde could we please test and merge |
Kyle-Ye
reviewed
Oct 2, 2022
|
@Kyle-Ye fixed! |
Kyle-Ye
reviewed
Oct 2, 2022
Kyle-Ye
reviewed
Oct 2, 2022
|
Closing older PRs after re-core of swift-corelibs-foundation on swift-foundation (#5001). |
Co-Authored-By: Kyle <[email protected]>
parkera
reviewed
Dec 19, 2024
| @@ -1149,7 +1149,11 @@ open class Process: NSObject, @unchecked Sendable { | |||
| // convenience; create and launch | |||
| open class func launchedProcess(launchPath path: String, arguments: [String]) -> Process { | |||
| let process = Process() | |||
| process.launchPath = path | |||
| if #available(macOS 10.13, *) { | |||
There was a problem hiding this comment.
With our new approach to swift-corelibs-foundation, it no longer builds for macOS. So, I think in the end this ifdef is not required - we can just always use the URL version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use executableURL instead of launchPath