Skip to content

Remove comment and error from back when CodeWarrior was used #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AZero13
Copy link
Contributor

@AZero13 AZero13 commented Oct 19, 2021

We aren't using CodeWarrior anymore. Let's fixup the function definition to match documentation and do struct assignment.

@AZero13 AZero13 changed the title Remove comment and error from 1999 Remove comment and error from back when CodeWarrior was a thing Oct 20, 2021
@AZero13 AZero13 changed the title Remove comment and error from back when CodeWarrior was a thing Remove comment and error from back when CodeWarrior was used Oct 20, 2021
@millenomi
Copy link
Contributor

@swift-ci please test and merge

@AZero13 AZero13 force-pushed the CreateWithBytes branch 2 times, most recently from e54d6f5 to f9a934c Compare November 12, 2021 15:48
@AZero13 AZero13 force-pushed the CreateWithBytes branch 2 times, most recently from a20babf to f93db84 Compare January 25, 2022 18:28
@AZero13 AZero13 requested review from xwu and removed request for xwu March 17, 2023 15:33
Remove the same warning from CFUUIDGetConstantUUIDWithBytes

We can do this as it's the same function as CreateWithBytes, except a different value for the third parameter is passed to __CFUUIDCreateWithBytesPrimitive
@parkera
Copy link
Contributor

parkera commented Jul 19, 2024

Closing older PRs after re-core of swift-corelibs-foundation on swift-foundation (#5001).

@parkera parkera closed this Jul 19, 2024
@AZero13 AZero13 deleted the CreateWithBytes branch December 18, 2024 08:08
@AZero13 AZero13 restored the CreateWithBytes branch December 18, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants