Restore previous value of Decimal.leastFiniteMagnitude for compatibility and deprecate
#3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity and deprecate.
|
@swift-ci test |
spevans
requested changes
Aug 31, 2021
|
@spevans Let's start that discussion then, since the property is both useless and misleading and should definitely be deprecated. Plus it has a trivial replacement, so there's minimal burden to users to update. |
|
Sorry, I meant it would be up to the Foundation team to decide on the API change, so just removing the deprecation change would allow the PR to go through whilst they come to a decision. Personally I think its a reasonable change. cc @millenomi |
|
I'm okay with the deprecation. @phausler, any objections? |
|
nah, this is fine to deprecate |
spevans
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #3067.