Make constants immortal #3063
Merged
Make constants immortal #3063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
parkera
approved these changes
Aug 27, 2021
|
Is there any way we can verify this with a test case? |
|
@parkera I think there might be. It's not going to be pretty, but I think I can make it work. |
rdar://82441851
drexin
force-pushed
the
wip-immortal-constants
branch
from
886ece7 to
1a3b9a3
Compare
|
@swift-ci test |
parkera
reviewed
Aug 27, 2021
| let trueRefCount = truePtr.advanced(by: 1).pointee | ||
| let falseRefCount = falsePtr.advanced(by: 1).pointee | ||
|
|
||
| XCTAssertEqual(trueRefCount, falseRefCount) |
There was a problem hiding this comment.
I'm not sure we need to actually verify the reference count, so much as verify that releasing it a bunch then using it doesn't crash.
There was a problem hiding this comment.
It's actually important that it doesn't change. Otherwise we are just masking the problem by assigning a very high ref count.
This was referenced Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://82441851