Skip to content

[5.4] SR-14108: Implement copy() in DateFormatter. #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2021
Merged

[5.4] SR-14108: Implement copy() in DateFormatter. #3011

merged 2 commits into from
Jul 18, 2021

Conversation

YOCKOW
Copy link
Member

@YOCKOW YOCKOW commented Jul 18, 2021

This PR contains cherry-picks from #3008 for Swift 5.4 branch.

DateFormatter.copy() returns the same instance not a copied one so far.
This PR adds an implementation of copy() in DateFormatter to behave expectedly(i.e. The same behavior with DarwinFoundation).

Resolves SR-14108.

@YOCKOW YOCKOW mentioned this pull request Jul 18, 2021
Merged
@spevans
Copy link
Contributor

spevans commented Jul 18, 2021

@swift-ci test

@spevans
Copy link
Contributor

spevans commented Jul 18, 2021

cc @drexin

drexin
drexin approved these changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drexin drexin merged commit 8c439c5 into swiftlang:release/5.4 Jul 18, 2021
@YOCKOW YOCKOW deleted the swift-5.4/SR-14108 branch July 19, 2021 01:02
@YOCKOW YOCKOW mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drexin drexin drexin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YOCKOW @spevans @drexin