Fix temporary filename coda going above the maximum path length in some cases #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porary directory paths by hashing the filename for the mkstemp template This limits the temp filename to a maximum of 31 characters. Fixes <https://bugs.swift.org/browse/SR-14823>.
millenomi
changed the title
|
cc @compnerd is Windows atomic writing broken? The Windows path above this seems to be using the temporary directory always, which may mean that .atomic writes on a volume other than |
|
Never mind — it uses |
|
@swift-ci please test |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that would occur if the filename for a temporary file plus the
.tmp.<coda>suffix was beyond the maximum path limit, but would be fine without it. This limits the temp filename to a maximum of 31 characters.There will be follow-ups for other situations where long paths have similar issues, but this one specifically is also going to be nominated for 5.4.x and 5.5.
Fixes https://bugs.swift.org/browse/SR-14823.