Add necessary missing TARGET_OS_BSD directives. #2990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
spevans
reviewed
Mar 18, 2021
| @@ -1649,7 +1649,7 @@ int _CFOpenFile(const char *path, int opts) { | |||
| } | |||
|
|
|||
| CF_CROSS_PLATFORM_EXPORT void *_CFReallocf(void *ptr, size_t size) { | |||
| #if TARGET_OS_WIN32 || TARGET_OS_LINUX | |||
| #if TARGET_OS_WIN32 || TARGET_OS_LINUX || defined(__OpenBSD__) | |||
There was a problem hiding this comment.
Would it be worth adding a TARGET_OS_OPENBSD?
There was a problem hiding this comment.
I don't know if it would be worth it. There shouldn't be too many points of divergence. Here, FreeBSD has reallocf and OpenBSD doesn't.
|
@swift-ci test linux |
|
Test failure appears unrelated, I think. |
|
@swift-ci test linux |
|
@swift-ci test |
3405691582
force-pushed
the
OpenBSDSupportSimple
branch
from
ef1c56e to
51865df
Compare
A number of Foundation tests are failing on OpenBSD due to these missing directives, or are required for other reasons. Fuller Foundation support will be completed in other commits.
3405691582
force-pushed
the
OpenBSDSupportSimple
branch
from
51865df to
9ac5bbc
Compare
|
Directives added for CFUtilities.c while we are here. @spevans can we retest and merge if everything else is OK? |
|
@swift-ci test |
spevans
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of Foundation tests are failing on OpenBSD due to these missing
directives, or are required for other reasons.
There is still more complex work to get full support for Foundation on
this platform but this will be handled in other commits.