JSONDecoder: Check that a parsed float does not return infinity. #2989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The behaviour of the floating point string parsing for Float and Double was changed to return +/-infinity instead of nil on overflow. (swiftlang/swift#34339) - Add an isFinite check to ensure that the result of a floating point conversion still fits in the type, matching current behaviour.
|
@swift-ci test |
|
cc @fabianfett |
fabianfett
approved these changes
Mar 8, 2021
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of the floating point string parsing for Float and
Double was changed to return +/-infinity instead of nil on overflow.
(When parsing floating-point from String, underflow to 0, overflow to ∞ swift#34339)
Add an isFinite check to ensure that the result of a floating point
conversion still fits in the type, matching current behaviour.