JSON Decoding based on JSONValue #2985
Conversation
|
@swift-ci test |
| @@ -737,3 +701,48 @@ private extension JSONValue { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| extension NSNumber { | |||
| static func fromJSONNumber(_ string: String) -> NSNumber? { | |||
There was a problem hiding this comment.
This should probably be a constructor (init?(jsonNumberString string: String)).
There was a problem hiding this comment.
In some cases this might return a NSDecimalNumber. I don't think that we can make it work with a convenience initializer (which is the only option we have in an extension).
There was a problem hiding this comment.
Yeah seems to be the case even though NSDecimalNumber is a subclass of NSNumber
|
@bendjones Can you take a look? @fabianfett is working on a full reimplementation at the Swift layer of JSONSerialization in SCF, and this patch has performance improvements by accessing the underlying JSONSerialization implementation instead of calling into JSONSerialization and then working on the returned values. |
fabianfett
force-pushed
the
ff-json-decoding
branch
from
7ece173 to
a912c67
Compare
|
@swift-ci test |
|
swiftlang/sourcekit-lsp#372 |
|
@swift-ci test |
fabianfett
force-pushed
the
ff-json-decoding
branch
from
a912c67 to
0efd82e
Compare
|
@swift-ci test |
|
|
||
| guard let value = try self.decoder.unbox(entry, as: UInt.self) else { | ||
| throw DecodingError.valueNotFound(type, DecodingError.Context(codingPath: self.decoder.codingPath, debugDescription: "Expected \(type) value but found null instead.")) | ||
| @inline(__always) private func decodeFixedWidthInteger<T: FixedWidthInteger>() throws -> T { |
There was a problem hiding this comment.
Isn't the trick for really really I mean it inline me @inlinable @inline(__always)?
There was a problem hiding this comment.
@inlinable can only be applied to public functions AFAIK.
There was a problem hiding this comment.
Ah true that's the time to use that trick...
|
Merging pending test passes. |
| // | ||
| // Created by Fabian Fett on 02.03.21. | ||
| // Copyright © 2021 Swift. All rights reserved. | ||
| // |
There was a problem hiding this comment.
Needs a better header? Or maybe file is redundant?
There was a problem hiding this comment.
urgh. this file was not intended to be commited.
fabianfett
force-pushed
the
ff-json-decoding
branch
from
0efd82e to
6be5d3f
Compare
|
@swift-ci test |
|
|
||
| if let double = Double(numberString) { | ||
| return Decimal(double) | ||
| } |
There was a problem hiding this comment.
It might be best avoid the fallback to Double parsing. Converting a Double to Decimal is lossy and if the string does not parse as a Decimal anyway it can be considered an invalid value for the type.
fabianfett
force-pushed
the
ff-json-decoding
branch
from
6be5d3f to
5ed74d3
Compare
|
@swift-ci test |
This is a follow up pr to #2966.
It should significantly improve overall JSON performance, since we save on a lot of roundtrips through
NSArrayandNSDictionary.