JSONSerialization: Improve number parsing for JSON #2980
Conversation
|
@swift-ci test |
spevans
force-pushed
the
pr_json_number_parsing
branch
from
7a310cd to
c93c307
Compare
|
@swift-ci test |
spevans
force-pushed
the
pr_json_number_parsing
branch
2 times, most recently
from
ab86b7a to
11685c3
Compare
|
@swift-ci test |
Sources/FoundationXML/XMLNode.swift
Outdated
| @@ -14,7 +14,7 @@ import SwiftFoundation | |||
| import Foundation | |||
| #endif | |||
| @_implementationOnly import CoreFoundation | |||
| @_implementationOnly import CFXMLInterface | |||
There was a problem hiding this comment.
Unintentionally added during commit?
| @@ -13,7 +13,7 @@ import SwiftFoundation | |||
| import Foundation | |||
| #endif | |||
| @_implementationOnly import CoreFoundation | |||
| @_implementationOnly import CFXMLInterface | |||
There was a problem hiding this comment.
Unintentionally added during commit?
spevans
force-pushed
the
pr_json_number_parsing
branch
2 times, most recently
from
c41803b to
25c8f39
Compare
|
@swift-ci test |
| var fractionExponent: Int? | ||
| var exponentValue: Int? | ||
| var negativeExponent = false | ||
| var jsonString = "" |
There was a problem hiding this comment.
Thanks so much for moving your implementation into this parseNumber function! 👍 I guess the only thing left from my side here, is the creation of jsonString. In my point of view, we should only create the jsonString at the very end of the number parsing based on the numbers arraySlice.
self.makeStringFast(self[numberStartIndex ..< self.readerIndex])Appending to a String especially with Character(UnicodeScalar(ascii)) is, if I recall correctly, very slow.
spevans
force-pushed
the
pr_json_number_parsing
branch
from
25c8f39 to
c173435
Compare
|
@swift-ci test |
spevans
force-pushed
the
pr_json_number_parsing
branch
from
c173435 to
953b800
Compare
|
@swift-ci test |
spevans
force-pushed
the
pr_json_number_parsing
branch
from
953b800 to
7c223ec
Compare
|
@swift-ci test |
- Add _JSONNumber and _NSJSONNumber, an internal subclass of NSNumber, to provide lazy parsing of numbers at time of use. This avoids parsing numbers as Decimal when later bridged to Double/Float and vice-versa which has accuracy issues if converted from one to the other. - Add test cases for SR-7054 and SR-12244
spevans
force-pushed
the
pr_json_number_parsing
branch
from
7c223ec to
a5887b7
Compare
|
@swift-ci test |
|
Closing older PRs after re-core of swift-corelibs-foundation on swift-foundation (#5001). |
This is a potential solution for SR-7054 and SR-12244 involving parsing JSON numbers and then later bridging them to
Decimalor a floating point type and losing accuray compared to the original input. It will need to be updated after #2966 is merge but that will be minimal changes. The bridging should also be marginally faster as it doesnt need to create a 2ndNSNumberfor the equality check.Add _NSJSONNumber, an internal subclass of NSNumber to provide lazy
parsing of numbers at time of use. This avoids parsing numbers as
Decimal when later bridged to Double/Float and vice-versa which
has accuracy issues if converted from one to the other.
Add test cases for SR-7054 and SR-12244