Skip to content

dont include objc when INCLUDE_OBJC not set #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

holymonson
Copy link

We don't need objc for pure CoreFoundation. I check the blame history it seems this logic is what you want.

We don't need objc for pure CoreFoundation.
@holymonson holymonson changed the title dont include objc when INCLUDE_OBJC set dont include objc when INCLUDE_OBJC not set Jan 21, 2021
@YOCKOW

This comment has been minimized.

@YOCKOW

This comment has been minimized.

@YOCKOW

This comment has been minimized.

@shahmishal

This comment has been minimized.

@YOCKOW

This comment has been minimized.

@YOCKOW
Copy link
Member

YOCKOW commented Dec 8, 2021

#3110 seems opposite to this.
@holymonson Do you have any thoughts?

@holymonson
Copy link
Author

#3110 seems opposite to this.

Not accurately. #3110 wants not implicitly include objc on win32, while this PR make not implicitly include objc on all platform. I think this one should be merged because it solves #3110 too.

@YOCKOW
Copy link
Member

YOCKOW commented Dec 8, 2021

#3110 seems opposite to this.

Not accurately. #3110 wants not implicitly include objc on win32, while this PR make not implicitly include objc on all platform. I think this one should be merged because it solves #3110 too.

Thank you for your response. That's fair enough.
Now I should request proper persons for review...

@YOCKOW YOCKOW requested review from millenomi and compnerd December 8, 2021 04:28
@YOCKOW
Copy link
Member

YOCKOW commented Dec 8, 2021

@swift-ci Please test

@compnerd
Copy link
Member

compnerd commented Dec 9, 2021

I think that I would like @millenomi or @parkera to chime in on this - I suspect that this impacts more than just the OSS builds.

@parkera
Copy link
Contributor

parkera commented Jul 19, 2024

Closing older PRs after re-core of swift-corelibs-foundation on swift-foundation (#5001).

@parkera parkera closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants