TestFoundation: stop internal http server on test case tear down #2958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving server running consumes one thread from Dispatch global thread pool per one started LoopbackServerTest. There are 5 such test cases at the moment. On non-Darwin platforms thread pool size is extremely small (equals to the number of CPU cores), and TestFoundation test case quickly becomes unstable on some machines (e.g. cloud VMs with 2-core CPUs).
|
@swift-ci please test |
|
Note that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving server running consumes one thread from Dispatch global thread pool per one started
LoopbackServerTest. There are 5 such test cases at the moment.On non-Darwin platforms thread pool size is extremely small (equals to the number of CPU cores), and TestFoundation test suite quickly becomes unstable on some machines (e.g. cloud VMs with 2-core CPUs).
This has no significant impact on current CMake-generated tests, as they are started as separate process each, but trying to run whole TestFoundation suite would hang or fail some trivial tests just because global queue is stuck.