Foundation: make -enable-library-evolution build
#2892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building Foundation with library evolution (resilience), we fail to build due to `RangeReference` being internal and marked as `@usableFromInline` but used in an `@inlinable` `public` context, exposing the type. Additionally, the constructor was internal and `@inlinable` which requires the constructor to be delegating. Additionally, because `Data.init(bytes:length:copy:deallocator)` is used in a public context, it leaks and results in an undefined reference to the allocating initializer. This allows building Foundation with library evolution, though exposes some of the internal interfaces.
|
Closing older PRs after re-core of swift-corelibs-foundation on swift-foundation (#5001). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Foundation with library evolution (resilience), we fail to
build due to
RangeReferencebeing internal and marked as@usableFromInlinebut used in an@inlinablepubliccontext,exposing the type. Additionally, the constructor was internal and
@inlinablewhich requires the constructor to be delegating.Additionally, because
Data.init(bytes:length:copy:deallocator)is usedin a public context, it leaks and results in an undefined reference to
the allocating initializer.
This allows building Foundation with library evolution, though exposes
some of the internal interfaces.