Skip to content

Remove unused variable in CFRegularExpression.c #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

Remove unused variable in CFRegularExpression.c #2871

merged 1 commit into from
Sep 13, 2022

Conversation

valeriyvan
Copy link
Contributor

No description provided.

@spevans
Copy link
Contributor

spevans commented Sep 4, 2020

@swift-ci test

@MaxDesiatov MaxDesiatov changed the title Removes not used variable Remove unused variable in CFRegularExpression.c Sep 4, 2020
@MaxDesiatov MaxDesiatov changed the base branch from master to main September 28, 2020 21:59
@valeriyvan
Copy link
Contributor Author

@millenomi, could you please review this PR?

etcwilde
etcwilde reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but still get approval from @millenomi.

@AZero13
Copy link
Contributor

AZero13 commented Sep 11, 2022

@millenomi ping?

@parkera parkera merged commit a9bf8d5 into swiftlang:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde left review comments

@parkera parkera parkera approved these changes

@millenomi millenomi Awaiting requested review from millenomi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valeriyvan @spevans @AZero13 @parkera @etcwilde