Remove unused variable in CFStringUtilities.c #2870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
changed the title
|
@millenomi lmk if you'd like to review trivial PRs such as this, or I could merge them otherwise |
|
I have these patches on temporary pause — the Core Foundation sources in this repo are produced by processing other source. Historically, every fall we merge in code to master from new releases, and I'm in the middle of figuring out how to do that for this year, and each small change adds some burden to that. As soon as the new merge-in PR is posted, these then become good to merge. |
|
How may I know that we could move further? I see a lot of other things like these ones which could and should be fixed. |
|
ping |
1 similar comment
|
ping |
Merged
|
Any update on this @parkera |
|
ping |
parkera
approved these changes
Nov 17, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.