Skip to content

[5.2] SR-13015: Decimal calculation incorrect on Linux #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2020
Merged

[5.2] SR-13015: Decimal calculation incorrect on Linux #2841

merged 1 commit into from
Jul 24, 2020

Conversation

finagolfin
Copy link
Member

From #2827, see explanation there.

@finagolfin
SR-13015: Decimal calculation incorrect on Linux
cc25c46 
Fix typo and logic error in the overflow check in integerMultiply(), which was
screwing up Decimal calculations under certain conditions.

(cherry picked from commit 81fddf2)
@spevans
Copy link
Contributor

spevans commented Jul 9, 2020

@swift-ci test

@finagolfin
Copy link
Member Author

The tests didn't run?

@spevans
Copy link
Contributor

spevans commented Jul 9, 2020

cc @millenomi

@finagolfin
Copy link
Member Author

finagolfin commented Jul 10, 2020 •
edited
Loading

macOS failure is unrelated- looks like the 5.2.4 compiler doesn't build with the XCode 12 beta on the CI, also seen with #2840- linux passes.

@ktoso
Copy link

ktoso commented Jul 10, 2020

AFAIK we're waiting on the macOS Swift CI to be updated with the latest toolchain, I believe this is going to be solved soon but don't have an estimate for it.

@spevans
Copy link
Contributor

spevans commented Jul 15, 2020

@swift-ci test macos

@finagolfin
Copy link
Member Author

Is someone working on getting the macOS CI going with this branch again? If not, maybe the macOS CI can be ignored, if 5.2.5 will be another linux-only release like 5.2.3.

@drexin
Copy link
Contributor

drexin commented Jul 24, 2020

@swift-ci test 5.2 macos

@finagolfin
Copy link
Member Author

macOS CI didn't get command?

@drexin
Copy link
Contributor

drexin commented Jul 24, 2020

@buttaface Yeah, we are working on it. I just want to make sure it passes on macOS before merging. We won't close the merge window before that.

@drexin
Copy link
Contributor

drexin commented Jul 24, 2020

@swift-ci test 5.2 macos

drexin
drexin approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahmishal shahmishal merged commit 143dcd7 into swiftlang:swift-5.2-branch Jul 24, 2020
@finagolfin finagolfin deleted the swift-5.2-branch branch July 27, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drexin drexin drexin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@finagolfin @spevans @ktoso @drexin @shahmishal