fix convenience accessors on CocoaError and URLError #2828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to add |
|
Will do. Amusingly I actually avoided committing my changes to |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test and merge |
|
@swift-ci please test and merge |
This was referenced Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convenience accessors (such as
URLError.failingURL) were always returningnilbecause they hashed the key using theNSStringhashValue rather than theStringhashValue. This PR fixes this, and adds simple test cases to exercise each accessor.Thanks @spevans for feedback about this in #2825.
This fixes https://bugs.swift.org/browse/SR-13037