SR-12366: URL: standardizedFileURL inconsistent behavior on macOS and Linux #2808
+118
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Linux - When NSURL._resolvingSymlinksInPath() was creating a new URL(), it would use the default logic of checking if the file was a directory. Override this behaviour and use the .hasDirectoryPath property of the original NSURL when creating the resultant URL. - Modify NSURL.standardized to remove use of force-unwrap. - Add TestNSURL.swift for NSURL tests.
|
@swift-ci test please |
|
@swift-ci please test |
|
@swift-ci test linux |
|
@compnerd Could you please test this on windows? If dabbles with file paths so I just want to check it doesn't break anything, thanks. |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NSURL._resolvingSymlinksInPath() was creating a new URL(), it
would use the default logic of checking if the file was a directory.
Override this behaviour and use the .hasDirectoryPath property of the
original NSURL when creating the resultant URL.
Modify NSURL.standardized to remove use of force-unwrap.
Add TestNSURL.swift for NSURL tests.