Skip to content

Add SPI for sources and observers to RunLoop #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2020
Merged

Add SPI for sources and observers to RunLoop #2807

merged 6 commits into from
May 30, 2020

Conversation

millenomi
Copy link
Contributor

These are for XCTest use only for now. This is to support appropriate changes to swiftlang/swift-corelibs-xctest#304.

millenomi added 3 commits May 27, 2020 10:07
@millenomi
Add SPI for sources and observers to RunLoop
3ff76f0 
These are for XCTest use only for now.
@millenomi
Corrections:
f0126a3 
- Members should match the publicness/openness of their containers
- Add a warning to getCFRunLoop() to warn porters that it's not going to be around forever.
@millenomi
For completeness, add _remove(_Source, for: Mode)
a8cd65c
@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi millenomi mentioned this pull request May 27, 2020
Closed
millenomi
millenomi commented May 27, 2020
View reviewed changes
Sources/Foundation/RunLoop.swift Outdated
}

@available(*, deprecated, message: "For XCTest use only.")
open func remove(_ source: _Source, for mode: RunLoop.Mode) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be underscored. A moment.

@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi
Copy link
Contributor Author

@swift-ci please test

3 similar comments
@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi
Copy link
Contributor Author

@swift-ci please test

compnerd
compnerd reviewed May 28, 2020
View reviewed changes
Sources/Foundation/RunLoop.swift Outdated
let me = Unmanaged<_Source>.fromOpaque(info!).takeUnretainedValue()
return .passRetained(String(describing: me)._cfObject)
},
equal: { (infoA, infoB) -> DarwinBoolean in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DarwinBoolean is not portable, can we not use the DarwinBoolean -> Bool bridging here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a case where the types are different between platforms and I just need to drop the return value there, I think.

Copy link
Contributor Author

@millenomi millenomi May 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File this under: why we want to stop exposing CF.

@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi
Copy link
Contributor Author

The module cache strikes again.

@millenomi
Copy link
Contributor Author

@swift-ci please test

@compnerd
Copy link
Member

Windows Run: https://dev.azure.com/compnerd/swift-build/_build/results?buildId=32451&view=results (looks good!)

@compnerd
Copy link
Member

s-p-m flakeyness :-(

@compnerd
Copy link
Member 

15:05:52 executionFailure(error: terminated(1): /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/buildbot_linux/swiftpm-linux-x86_64/x86_64-unknown-linux-gnu/release/swift-build --package-path /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/tmp/Miscellaneous_-DSWIFT_PACKAGE.xVffhC/Miscellaneous_-DSWIFT_PACKAGE --configuration release -Xcc -DEXTRA_C_DEFINE=2 -Xswiftc -DEXTRA_SWIFTC_DEFINE output:
15:05:52     [1/2] Compiling CLib foo.c
15:05:52     [2/3] Compiling SwiftExec main.swift
15:05:52     <unknown>:0: warning: missing submodule 'CLib'

@compnerd
Copy link
Member

@swift-ci please test Linux platform

@millenomi millenomi merged commit 2462fc4 into swiftlang:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millenomi @compnerd @smumriak