Base64: Speedup encoding fix 3 #2803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
spevans
force-pushed
the
base64encode-speedup3
branch
from
f1160b7 to
cd5f0e4
Compare
|
@swift-ci test |
|
@swift-ci please test |
- Pass UnsafeRawBufferPointers to NSData.base64EncodeBytes() and make the Data.base64EncodedString() and Data.base64EncodedData() methods call it directly. - There is considerable overhead in forwarding the methods from Data to NSData. Making the Data methods directly call NSData.base64EncodeBytes() removes this overhead.
spevans
force-pushed
the
base64encode-speedup3
branch
from
cd5f0e4 to
0927904
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass UnsafeRawBufferPointers to NSData.base64EncodeBytes() and make
the Data.base64EncodedString() and Data.base64EncodedData() methods
call it directly.
There is considerable overhead in forwarding the methods from Data to
NSData. Making the Data methods directly call NSData.base64EncodeBytes()
removes this overhead.