Allow whitespaces after parsed content in DateFormatter.date(from:) #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test linux |
|
@swift-ci please test |
spevans
reviewed
May 10, 2020
Apple implementation checks for unparsed content in source string. Any non-whitespace leftover characters are considered as failure. On the other hand, whitespaces are permitted and should not affect the result. The check was partially implemented in swiftlang#1822 (SR-9322). This patch alters verification logic to be closer to Apple implementation.
lxbndr
force-pushed
the
date-formatter-whitespaces
branch
from
fd2f66c to
dd22d7d
Compare
|
@swift-ci test linux |
|
@swift-ci please test linux |
|
Gotta say please. 😇 |
|
By the way, macOS works now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the difference between macOS and Windows test results in our codebase (we are heavily dependent on date parsing). I have not found any docs about this, but actual results and deep debugging left no doubt about the mechanics.
Apple implementation checks for unparsed content in source string.
Any non-whitespace leftover characters are considered as failure.
On the other hand, whitespaces are permitted and should not affect the result.
Related to #1822 (SR-9322).
This patch alters verification logic to be closer to Apple implementation.
Not sure about
preconditionFailurecheck, but that's really unexpected condition.cc @compnerd @spevans