Balance OperationQueue retain/release #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prevent releasing of stored value in `Operation._queue` property getter - balance retain count after current queue removed from thread-specific storage - make test_OperationWaitUntilFinished stable - extend test_OperationCount
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
|
Windows build looks good as well. This seems correct to me. |
|
Will this be able to make it into Swift 5.3? Seems like a pretty nasty bug. |
|
@broadwaylamb I created #2831 to backport some OperationQueue fixes to 5.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operation._queueinternal property does release stored value on every getter call. In most scenarios it is accessed exactly once, and balanced by "leaking" same value to Thread Specific storage. But under some conditions_queueis accessed twice, and crash is inevitable.I strongly believe that property accessor should not release its value. Kind of typo for me. Operation already has the pair of
_adopt(queue:schedule:)/_invalidateQueue()functions intended to manage ownership of queue, and they are used in proper places.This patch
Operation._queueproperty gettercc @compnerd @spevans @millenomi