Adjust test_dateFromDoesntMutate expectations #2778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI runs in UTC time zone, and this affects the description of TimeZone being tested.
|
Ugh, that’s super . Nice catch! |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
|
NSOperation tests are still flakey, but that isn't related to this. LGTM. |
Oh, interesting. It is from the new test set. Never stepped on this before. Operation notifies about completion a moment before it is removed from Queue. I guess it is expected behavior, and check in the test just fires too early. Queue needs some time to remove finished Operation. Looks like we need to adjust test to wait a little before assertion check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI runs in UTC time zone, and this affects the description of TimeZone being tested.
CC @compnerd