-
Notifications
You must be signed in to change notification settings - Fork 1.1k
JSONSerialization: Add support for .withoutEscapingSlashes, .fragmentsAllowed #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
419c8d4
to
cd3b9b2
Compare
@swift-ci test linux |
1 similar comment
@swift-ci test linux |
cd3b9b2
to
c926720
Compare
@swift-ci test linux |
@swift-ci test linux |
bendjones
reviewed
Apr 6, 2020
bendjones
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nit but overall this LGTM @millenomi
- JSONEncoder now encodes fragments by default to match Darwin. - JSONDecoder now allows fragments when decoding to match Darwin. - Update the following TestJSONEncoder tests now that fragments encode, these tests now pass on Darwin: test_encodingTopLevelSingleValueEnum test_encodingTopLevelSingleValueStruct test_encodingTopLevelSingleValueClass
c926720
to
09fca84
Compare
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes SR-12275: JSONEncoder on Linux can't encode number JSON fragments
JSONEncoder now encodes fragments by default to match Darwin.
JSONDecoder now allows fragments when decoding to match Darwin.
Update the following TestJSONEncoder tests now that fragments encode,
these tests now pass on Darwin:
test_encodingTopLevelSingleValueEnum
test_encodingTopLevelSingleValueEnum
test_encodingTopLevelSingleValueClass