TimeZone: delegate to ICU on Windows #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millenomi
reviewed
Feb 22, 2020
| @@ -1679,18 +1679,34 @@ CFTimeInterval CFTimeZoneGetDaylightSavingTimeOffset(CFTimeZoneRef tz, CFAbsolut | |||
| return 0.0; | |||
| } | |||
|
|
|||
| extern UCalendar *__CFCalendarCreateUCalendar(CFStringRef calendarID, CFStringRef localeID, CFTimeZoneRef tz); | |||
There was a problem hiding this comment.
should this be CF_PRIVATE? what's the tag on that function?
There was a problem hiding this comment.
I'm not sure, it was just moved up from below in the same file. Pretty sure its meant to be private.
There was a problem hiding this comment.
My bad, I just saw the removal under it.
Unfortunately, Windows does not have full time zone information available. For many cases we can make do with the system information, augmented with alternate names (the Olson-to-Windows conversion database). This papers over the inability to deserialize the full information in the registry by falling back to ICU to get the information for the DST time conversion.
compnerd
force-pushed
the
delegating-muscle
branch
from
9e32385 to
19af385
Compare
|
Otherwise approved. |
|
@swift-ci please test Linux platform |
millenomi
approved these changes
Feb 22, 2020
| @@ -1679,18 +1679,34 @@ CFTimeInterval CFTimeZoneGetDaylightSavingTimeOffset(CFTimeZoneRef tz, CFAbsolut | |||
| return 0.0; | |||
| } | |||
|
|
|||
| extern UCalendar *__CFCalendarCreateUCalendar(CFStringRef calendarID, CFStringRef localeID, CFTimeZoneRef tz); | |||
There was a problem hiding this comment.
My bad, I just saw the removal under it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, Windows does not have full time zone information
available. For many cases we can make do with the system information,
augmented with alternate names (the Olson-to-Windows conversion
database). This papers over the inability to deserialize the full
information in the registry by falling back to ICU to get the
information for the DST time conversion.