test: correct test assumption for Windows paths #2684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows file system path representation `\` is a drive letter relative path. That is, the same path can be used across multiple drives (similar to the concept of alternate roots). We expect that the path returned is `[[:letter:]]:` or `[[:letter:]]:[\\/]` rather than the Unix `/`. Adjust the expectation.
|
@swift-ci please test Linux platform |
millenomi
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows file system path representation
\is a drive letterrelative path. That is, the same path can be used across multiple
drives (similar to the concept of alternate roots). We expect that
the path returned is
[[:letter:]]:or[[:letter:]]:[\\/]ratherthan the Unix
/. Adjust the expectation.