Skip to content

Fix misleading local variable names #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

Fix misleading local variable names #2682

merged 1 commit into from
Jun 18, 2020

Conversation

revolter
Copy link
Contributor

No description provided.

@revolter revolter requested a review from phausler February 24, 2020 10:20
@millenomi
Copy link
Contributor

They're called 'max' because they are essentially the same as what is returned by NSMaxRange(), but it makes sense that one not versed in that would be confused.

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@spevans
Copy link
Contributor

spevans commented Apr 7, 2020

@swift-ci test linux

@revolter
Copy link
Contributor Author

revolter commented Apr 8, 2020

Is it stuck?

@xwu
Copy link
Contributor

xwu commented Apr 12, 2020

@swift-ci test

@revolter
Copy link
Contributor Author

This can be merged, as the failing tests are not related to my changes.

@revolter
Copy link
Contributor Author

I rebased it, maybe the tests will pass now.

@spevans
Copy link
Contributor

spevans commented Jun 18, 2020

@swift-ci please test and merge

@swift-ci swift-ci merged commit ff75ac8 into swiftlang:master Jun 18, 2020
@revolter revolter deleted the patch-1 branch June 18, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler Awaiting requested review from phausler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@revolter @millenomi @spevans @xwu @swift-ci