Skip to content

[5.2] SR-11569: DateComponents.isValidDate() ignores timeZone #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Jan 23, 2020

  • Call components(_:from:) using the correct calendar object with
    the correct time zone.

(cherry picked from commit 64a7907)

- Call components(_:from:) using the correct calendar object with
  the correct time zone.

(cherry picked from commit 64a7907)
@spevans
Copy link
Contributor Author

spevans commented Jan 23, 2020

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Jan 23, 2020

cc @millenomi

@spevans spevans requested a review from millenomi January 27, 2020 17:40
Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@drexin drexin merged commit ae27e1e into swiftlang:swift-5.2-branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants