[Windows] Added a test for _getFilesystemRepresentation #2367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2019
gmittert
changed the title
gmittert
force-pushed
the
UseWinFSR
branch
2 times, most recently
from
fdb10d4 to
75dda63
Compare
compnerd
approved these changes
Sep 23, 2019
|
@gmittert would you mind rebasing this change? I think most of the issues are taken care of, but I think it would get good ensure that everything is merged before closing this out. |
|
@compnerd looks like you got all the ones I found. The only thing left is the test that I added. I've rebased the change to just be the added test now. |
This ensures that paths are properly normalized when handed off to win32 functions.
|
@swift-ci please test |
gmittert
changed the title
|
@swift-ci please test Linux platform |
lxbndr
reviewed
Apr 27, 2020
| "\(tmpPath)\\testfile", // C:/Users/...\testfile | ||
| "\(tmpPath)/testfile", // C:/Users.../testfile | ||
| "\(tmpPath)/testfile", // /Users/user/.../testfile | ||
| "\(tmpPath.first!):testfile", // C:testfile |
There was a problem hiding this comment.
Btw, this fails when runner has no Administrator privileges. CI agents are usually elevated, but manual run as user would report failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small test to ensure that Windows FSRs don't regress