Foundation: correctly read thread name #2309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foundation was correctly setting the thread name, but it would only ever read the name that was stored in the thread object. This meant that if the thread name was set elsewhere (e.g. by Linux, or by SwiftNIO) that name would not be reflected in Thread's name property.
|
@swift-ci test |
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation was correctly setting the thread name, but it would only ever
read the name that was stored in the thread object. This meant that if
the thread name was set elsewhere (e.g. by Linux, or by SwiftNIO) that
name would not be reflected in Thread's name property.