Skip to content

Add unavailable pathWithComponents method for warning #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Add unavailable pathWithComponents method for warning #2298

merged 1 commit into from
Jun 3, 2020

Conversation

keith
Copy link
Member

@keith keith commented May 24, 2019

No description provided.

@keith keith mentioned this pull request May 24, 2019
Merged
@keith
Copy link
Member Author

keith commented May 24, 2019

I submitted this because of the comment here: #2290 (comment)

@keith
Copy link
Member Author

keith commented Jun 26, 2019

@millenomi are you still interested in this?

spevans
spevans reviewed Jun 26, 2019
View reviewed changes
@spevans
Copy link
Contributor

spevans commented Jul 3, 2019

@swift-ci test linux

@keith
Copy link
Member Author

keith commented Aug 5, 2019

@spevans looks like it didn't trigger, mind trying again?

@spevans
Copy link
Contributor

spevans commented Aug 5, 2019

@swift-ci test

@keith
Copy link
Member Author

keith commented Aug 19, 2019

@spevans looks like this one is green now!

@keith
Copy link
Member Author

keith commented May 13, 2020

@spevans friendly ping

@spevans
Copy link
Contributor

spevans commented May 13, 2020

@keith It looks like this needs to be rebased to fix some conflicts

@keith
Copy link
Member Author

keith commented May 13, 2020

Sorry, updated

@spevans
Copy link
Contributor

spevans commented May 14, 2020

@swift-ci please test

1 similar comment
@spevans
Copy link
Contributor

spevans commented May 14, 2020

@swift-ci please test

@keith
Copy link
Member Author

keith commented May 26, 2020

@spevans is this good to go now?

@spevans
Copy link
Contributor

spevans commented Jun 1, 2020

@swift-ci test and merge

@spevans
Copy link
Contributor

spevans commented Jun 1, 2020

@swift-ci please test and merge

4 similar comments
@spevans
Copy link
Contributor

spevans commented Jun 1, 2020

@swift-ci please test and merge

@spevans
Copy link
Contributor

spevans commented Jun 2, 2020

@swift-ci please test and merge

@spevans
Copy link
Contributor

spevans commented Jun 2, 2020

@swift-ci please test and merge

@spevans
Copy link
Contributor

spevans commented Jun 2, 2020

@swift-ci please test and merge

@spevans
Copy link
Contributor

spevans commented Jun 3, 2020

@swift-ci test linux

@spevans spevans merged commit 092c58a into swiftlang:master Jun 3, 2020
@keith
Copy link
Member Author

keith commented Jun 3, 2020

Thanks!

@keith keith deleted the ks/add-deprecated branch January 17, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spevans spevans spevans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith @spevans