Skip to content

TestFoundation: TestDateInterval: Add tests for functionality #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2019

Conversation

tillson
Copy link
Contributor

@tillson tillson commented Apr 23, 2019

Adds some functionality tests for the DateInterval interface.

  • This is my first pull request to this project, so let me know if there are any issues!

@tillson
Copy link
Contributor Author

tillson commented Apr 23, 2019

@swift-ci please test

1 similar comment
@spevans
Copy link
Contributor

spevans commented Apr 23, 2019

@swift-ci please test

@spevans
Copy link
Contributor

spevans commented Apr 23, 2019

@swift-ci test linux

@@ -10,10 +10,124 @@
class TestDateInterval: XCTestCase {
static var allTests: [(String, (TestDateInterval) -> () throws -> Void)] {
return [
("test_default_constructor", test_default_constructor),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we camelCase these?

@tillson
Copy link
Contributor Author

tillson commented Apr 23, 2019

@swift-ci test linux

@tillson
Copy link
Contributor Author

tillson commented Apr 24, 2019

Pardon my Git ignorance, I didn't realize that pushing to the forked master would automatically add
it to the pull request (I guess the lesson there is to submit a pull request via a branch).

@swift-ci test linux

@spevans
Copy link
Contributor

spevans commented Apr 24, 2019

@swift-ci test

@millenomi
Copy link
Contributor

@swift-ci please test

@spevans
Copy link
Contributor

spevans commented Apr 28, 2019

@swift-ci test

@tillson
Copy link
Contributor Author

tillson commented May 1, 2019

@swift-ci test

Is there something wrong?

@spevans
Copy link
Contributor

spevans commented May 1, 2019

@swift-ci test

@millenomi millenomi merged commit c80ec9a into swiftlang:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants