Foundation: build CoreFoundation as /MD #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
|
Seems reasonable |
compnerd
force-pushed
the
trust-me-i-am-a-MD
branch
from
da22467 to
d18b531
Compare
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
gwynne
suggested changes
Feb 16, 2019
Use /MD and /MDd mode compilation rather than /MT or /MTd as per Microsoft's recommendation. This allows us to use a shared C runtime. The static MSVCRT/ucrt cannot be intermingled with a dynamic one.
compnerd
force-pushed
the
trust-me-i-am-a-MD
branch
from
d18b531 to
186d942
Compare
|
@swift-ci please test |
gwynne
approved these changes
Feb 16, 2019
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use /MD and /MDd mode compilation rather than /MT or /MTd as per
Microsoft's recommendation. This allows us to use a shared C runtime.
The static MSVCRT/ucrt cannot be intermingled with a dynamic one.