NSURLComponents.hash: Implement #1648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
millenomi
reviewed
Aug 3, 2018
|
|
||
|
|
||
| func test_hash() { | ||
| let c1 = URLComponents(string: "https://www.swift.org/path/to/file.html?id=name")! |
There was a problem hiding this comment.
Same as in the other review, can we test changing all parts that contribute to the hash?
|
Closing; please see followup PR at #1656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSURLComponentsinheritshashfromNSObject, but overridesisEqual(_:)to compare contents. The default hash uses object identity, so twoNSURLComponentinstances that compare equal underisEqual(_:)can produce non-equal hash values. This also breaks hashing forURLComponents, which calls intoNSURLComponents.hash.Add an implementation for
NSURLComponents.hashthat matchesisEqual(_:).Resolves https://bugs.swift.org/browse/SR-8450