SR-8407: NSNumber as? Bool should only work for 0 or 1 #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NSNumber as? Bool should only work for NSNumber values 0 and 1 to match Darwin.
|
@swift-ci please test |
|
I recall @phausler doing a lot of work in this area last year as far as bridging goes; do we need to update it elsewhere here now that we have more consistent bridging with linux? |
phausler
approved these changes
Jul 31, 2018
|
|
||
| XCTAssertEqual(NSNumber(value: Int64.max).boolValue, true) | ||
| XCTAssertEqual(NSNumber(value: Int64.max - 1).boolValue, true) | ||
| XCTAssertEqual(NSNumber(value: Int64.min).boolValue, false) // Darwin compatibility |
There was a problem hiding this comment.
this is no longer the case, we finally fixed that in High Sierra.
There was a problem hiding this comment.
Are you sure? I tested on HS 10.13.6:
print(NSNumber(value: Int64.min).boolValue)
false
|
|
||
| XCTAssertEqual(NSNumber(value: Int.max).boolValue, true) | ||
| XCTAssertEqual(NSNumber(value: Int.max - 1).boolValue, true) | ||
| XCTAssertEqual(NSNumber(value: Int.min).boolValue, false) // Darwin compatibility |
| @@ -623,6 +624,37 @@ class TestNSNumberBridging : XCTestCase { | |||
| XCTAssertEqual(value, ns_value) | |||
| } | |||
| } | |||
|
|
|||
| func testNSNumberToBool() { | |||
There was a problem hiding this comment.
this is correct behavior, thanks for the update!
|
@parkera The behaviour for |
|
Ok, we can do that. |
This was referenced Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match Darwin.